Mantis Bugtracker          
testlink.org

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0008736TestLinkRequirement Version Comparepublic2019-08-05 13:022020-01-20 09:56
ReporterCHW01 
Assigned Tofman 
PrioritylowSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.9.19 (2019 Q1) 
Fixed in Version2.0 (planned) 
Summary0008736: Requirement versions compare page: user reported as 'undefined'
DescriptionThe Requirement versions compare page provides all available requirement versions and revisions for comparison.
Each version/revision is listed with the related time stamp and user information.

The user information is only correct for the initial version. All other entries display with user 'undefined'

This is only minor severity and low priority, because the user can still be found inside the actual version.
Steps To Reproduce- Create a requirement and freeze the version
- Create a new version of the requirement
- Create a new revision of the requirement
- Select the requirement and select option 'View history'

Now, the available versions display with the incorrect user information.
TagsNo tags attached.
Database (MySQL,Postgres,etc)MySQL
Browser
PHP Version
TestCaseID
QA Team - Task Workflow StatusTBD
Attached Filesjpg file icon incorrect user information.jpg [^] (106,030 bytes) 2019-08-05 13:02


png file icon dbContentAfterFix.png [^] (49,934 bytes) 2020-01-20 06:44


png file icon #8736 fixed.png [^] (56,018 bytes) 2020-01-20 09:25

- Relationships
related to 0008731resolvedfman last change made by undefined 

-  Notes
(0029070)
fman (administrator)
2019-08-05 16:34

please before reporting an issue look for similar one
(0029424)
heju (reporter)
2020-01-19 09:41

Observing the same issue. Pls have a look in the related ticket 0008731, added some info and thoughts.
(0029427)
fman (administrator)
2020-01-19 22:46

Please do the following changes and retry

https://github.com/TestLinkOpenSourceTRMS/testlink-code/commit/49e820cb0c20b3f4311863123803b6ac9a747f13 [^]

the issue seems related to how different MySQL versions consider a NULL timestamp
Some MySQL considers 0000-00-00 00:00:00 as the NULL, according to server configuration.
(0029428)
heju (reporter)
2020-01-20 06:44

Dear fman,

thanks for the quick response. Tested your fix briefly, works as expected.

I just see one minor issue which is related to the comment in the related issue:
After the fix still the modification_ts entry in the data base for the new revision can be misleading, as it is (for my mysql db) the modification_ts of the previous revision. (pls have a look at the scrennshot of the db content)

This can lead to a modification_ts "before" creation_ts which may be misleading.

Still only a cosmetic issue as this timestamp never gets displayed as the modifier_id is NULL.
(0029429)
fman (administrator)
2020-01-20 08:27

@heju
thanks for your collaboration.
A better fix IMHO will be change for all modification_ts the column to:

- allow NULL
- default NULL

then request that MySQL will be configured to use NULL and not 0000-00-00 00:00:00
(0029432)
CHW01 (reporter)
2020-01-20 09:21
edited on: 2020-01-20 09:24

@heju and @fman

Thank you both very much. I can only contribute by testing from a user perspective. Works as expected.

=> correct user ID and time stamp is now shown for:
- existing versions/revisions
- new changes

See also attached screenshot for user interface after fixe

(0029433)
fman (administrator)
2020-01-20 09:56

@CHW01 - great!!

- Issue History
Date Modified Username Field Change
2019-08-05 13:02 CHW01 New Issue
2019-08-05 13:02 CHW01 File Added: incorrect user information.jpg
2019-08-05 16:34 fman Note Added: 0029070
2019-08-05 16:38 fman Relationship added related to 0008731
2019-08-05 16:38 fman Status new => feedback
2020-01-19 09:41 heju Note Added: 0029424
2020-01-19 22:46 fman Note Added: 0029427
2020-01-20 06:44 heju Note Added: 0029428
2020-01-20 06:44 heju File Added: dbContentAfterFix.png
2020-01-20 08:27 fman Note Added: 0029429
2020-01-20 09:21 CHW01 Note Added: 0029432
2020-01-20 09:21 CHW01 Status feedback => new
2020-01-20 09:24 CHW01 Note Edited: 0029432 View Revisions
2020-01-20 09:25 CHW01 File Added: #8736 fixed.png
2020-01-20 09:56 fman Note Added: 0029433
2020-01-20 09:56 fman QA Team - Task Workflow Status => TBD
2020-01-20 09:56 fman Status new => resolved
2020-01-20 09:56 fman Fixed in Version => 2.0 (planned)
2020-01-20 09:56 fman Resolution open => fixed
2020-01-20 09:56 fman Assigned To => fman



Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker