MantisBT - TestLink
View Issue Details
0008477TestLinkGeneralpublic2018-11-15 15:542018-11-24 09:58
lordsqn 
fman 
normaltrivialalways
resolvedfixed 
WinWindows 10
1.9.18 (2018 Q3) 
1.9.19 (2019 Q1) 
MySQL57
Chrome
7.1
TBD
0008477: TestLink are not setting headers because of problem with translation loading
Hello everyone,

I found a problem with TestLink that is problematic for Polish users.
If you'll set Polish language as main it will cause that TestLink will be unable to send in response any proper header back to server.

It happening because file with Polish translation \locale\pl_PL\strings.txt is saved incorrectly as UTF-8 with BOM (should be UTF-8 without BOM) witch causing problem for method require() to parse it properly. It is parsed without any error but that BOM from settings.txt causing output to be polluted.

Because of that method header() not working at all, because it have to be called before anything else, witch causing more problems.
1. Install TestLink
2. Change language to Polish (pl_PL)
3. Add any file as attachment
4. Try to download it in Chrome

it will cause flushing a file into browser window because header is set to text/html.
Any header added in lib\attachments\attachmentdownload.php is ignored.
Please remove BOM from polish translation file in next release.
No tags attached.
child of 0008397assigned fman Availables hot-fixes for 1.9.18 & How To get full fixed package from GitHub 
txt strings.txt (190,559) 2018-11-19 13:24
http://mantis.testlink.org/file_download.php?file_id=5035&type=bug
Issue History
2018-11-15 15:54lordsqnNew Issue
2018-11-16 11:04fmanQA Team - Task Workflow Status => TBD
2018-11-16 11:04fmanPriorityhigh => normal
2018-11-17 08:31fmanNote Added: 0028245
2018-11-17 08:32fmanAssigned To => fman
2018-11-17 08:32fmanStatusnew => feedback
2018-11-19 13:24lordsqnFile Added: strings.txt
2018-11-19 13:25lordsqnNote Added: 0028248
2018-11-19 13:25lordsqnStatusfeedback => assigned
2018-11-24 09:03fmanNote Added: 0028266
2018-11-24 09:03fmanFixed in Version => 1.9.19 (2019 Q1)
2018-11-24 09:03fmanRelationship addedchild of 0008397
2018-11-24 09:58fmanStatusassigned => resolved
2018-11-24 09:58fmanResolutionopen => fixed

Notes
(0028245)
fman   
2018-11-17 08:31   
would you mind to provide the file with right coding ?
(0028248)
lordsqn   
2018-11-19 13:25   
Here you go. File is from official 1.9.18 version with correct encoding.
(0028266)
fman   
2018-11-24 09:03   
https://github.com/TestLinkOpenSourceTRMS/testlink-code/commit/70c3fd266e9af9c16499f4cb6ed5387b5aea1772 [^]