MantisBT - TestLink
View Issue Details
0007903TestLinkCode alignmentpublic2017-03-28 12:042018-04-14 09:04
abIng 
fman 
normalminorN/A
closedfixed 
1.9.14 (2015 Q3) 
1.9.17 (2018 Q1) 
N/A
READY FOR TESTING
0007903: cke_pastebin - missing changes for udpdate operations
Thank you for the quick and dirty solution of the problem http://mantis.testlink.org/view.php?id=7643 [^] related to copy and paste Under chrome.
I integrated it into my testlink after some modifications - see the section "Steps to reproduce".

One modification is related to a typing error Inside CKEditorCopyAndPasteCleanUp function.

Another one is due to the fact that the problem appears not only during create but also during update.

I tested the solution by simulating the problem, and I integrated additional logging to capture the problem as it appears.
Modifications:
1) In function CKEditorCopyAndPasteCleanUp replace
$items->$fi = str_ireplace($offending,$good,$items->$fi);
by
$items[$fi] = str_ireplace($offending,$good,$items[$fi]);

2) At the very beginning of the function update insert the code:
$tmp = array('summary' => $summary,'precondition' => $preconditions);
$this->CKEditorCopyAndPasteCleanUp($tmp,array('summary','precondition'));
$summary = $tmp['summary'];
$precondition = $tmp['precondition'];

3) At the very beginning of the function update_step insert the code:
$tmp = array('actions' => $actions,'expected_results' => $expected_results);
$this->CKEditorCopyAndPasteCleanUp($tmp,array('actions','expected_results'));
$actions = $tmp['actions'];
$expected_results = $tmp['expected_results'];


Implemented under 1.9.14 but it is the same for 1.9.16.
No tags attached.
related to 0007643closed fman Some testcases in edit mode appear blank and canĀ“t edit (reason: <body id="cke_pastebin") 
Issue History
2017-03-28 12:04abIngNew Issue
2017-03-28 14:51fmanNote Added: 0026217
2017-03-28 21:28fmanNote Added: 0026221
2017-03-28 21:30fmanRelationship addedrelated to 0007643
2017-03-28 21:30fmanQA Team - Task Workflow Status => TBD
2017-03-28 21:30fmanFixed in Version => 1.9.17 (2018 Q1)
2017-03-28 21:31fmanSummaryAgain cke_pastebin - some improvements => cke_pastebin - missing changes for udpdate operations
2017-03-28 21:32fmanNote Added: 0026222
2017-03-28 21:33fmanNote Added: 0026223
2017-03-28 21:33fmanAssigned To => fman
2017-03-28 21:33fmanStatusnew => feedback
2017-03-29 08:24abIngNote Added: 0026224
2017-03-29 08:24abIngStatusfeedback => assigned
2017-03-29 20:07fmanNote Added: 0026226
2017-03-29 21:44fmanStatusassigned => feedback
2017-04-08 08:39fmanQA Team - Task Workflow StatusTBD => READY FOR TESTING
2017-04-08 08:39fmanStatusfeedback => resolved
2017-04-08 08:39fmanResolutionopen => fixed
2018-04-14 09:04fmanNote Added: 0027337
2018-04-14 09:04fmanStatusresolved => closed

Notes
(0026217)
fman   
2017-03-28 14:51   
surely I've missed the apply fix to update and other situations.
thanks for help

regards
(0026221)
fman   
2017-03-28 21:28   
>> One modification is related to a typing error Inside CKEditorCopyAndPasteCleanUp function.
Can you explain what is the typo error?
(0026222)
fman   
2017-03-28 21:32   
https://github.com/TestLinkOpenSourceTRMS/testlink-code/commit/3e79efa9cc3dd766283150251d6c4d636c4ba490 [^]
(0026223)
fman   
2017-03-28 21:33   
Please get code , apply , retest & provide feedback
(0026224)
abIng   
2017-03-29 08:24   
Everything is OK except one line 619 in the function createVersion.
Instead of
$this->CKEditorCopyAndPasteCleanUp($item,array('summary','precondition'));
should be:
$this->CKEditorCopyAndPasteCleanUp($item,array('summary','preconditions'));
(0026226)
fman   
2017-03-29 20:07   
thanks a lot => commit done
(0027337)
fman   
2018-04-14 09:04   
release 1.9.17