MantisBT - TestLink
View Issue Details
0007746TestLinkAvailable Fixespublic2016-11-15 09:572017-01-22 07:57
DierickxD71 
fman 
normalmajoralways
closedfixed 
WindowsServer 2008
1.9.15 (2015 Q4) 
1.9.16 (2016 Q4) 
MySQL
TBD
0007746: Notification mails sent to inactive users (globalRole)
If the config(_custom).inc.php is configured with:
> $tlCfg->notifications->userSignUp->to->roles = array(TL_ROLES_ADMIN);
Then all global admins will receive notifications when a user signs up.
However, it also sends mails to the e-mail addresses of accounts that are now put to inactive.

For this I have a patch in GitHub, in the file "tlRole.class.php".
In the function "protected function getUserIDsWithGlobalRole(&$db)" I extended the WHERE-clause in the SQL as such:
> " WHERE role_id = {$this->dbID} AND active = 1";

I chose to do it in this location so that the fix works not only for TL_ROLES_ADMIN users, or only for new user signups, but that it works for any functionality and any global role.
No tags attached.
child of 0007666closed fman Availables hot-fixes for 1.9.15 & How To get full fixed package from GitHub 
Issue History
2016-11-15 09:57DierickxD71New Issue
2016-11-15 10:09DierickxD71Note Added: 0025563
2016-11-17 21:04fmanNote Added: 0025590
2016-11-17 21:10fmanNote Added: 0025591
2016-11-17 21:11fmanQA Team - Task Workflow Status => TBD
2016-11-17 21:11fmanFixed in Version => 1.9.16 (2016 Q4)
2016-11-17 21:11fmanAssigned To => fman
2016-11-17 21:11fmanStatusnew => feedback
2016-11-17 21:11fmanRelationship addedchild of 0007666
2016-12-24 14:51fmanNote Added: 0025784
2016-12-24 14:51fmanStatusfeedback => resolved
2016-12-24 14:51fmanResolutionopen => fixed
2017-01-22 07:57fmanNote Added: 0025873
2017-01-22 07:57fmanStatusresolved => closed

Notes
(0025563)
DierickxD71   
2016-11-15 10:09   
Pull request #68
(0025590)
fman   
2016-11-17 21:04   
Thanks for your help.
My choice is to add a new argument to
getUsersWithGlobalRole(&$db,$opt=null)
getUserIDsWithGlobalRole($db,$opt=nul)
(0025591)
fman   
2016-11-17 21:10   
https://github.com/TestLinkOpenSourceTRMS/testlink-code/commit/f486b7a69c95bcfaa448fd5dc12e99dde44dc02a [^]
(0025784)
fman   
2016-12-24 14:51   
no more user feedback
(0025873)
fman   
2017-01-22 07:57   
1.9.16 released