MantisBT - TestLink
View Issue Details
0007543TestLinkGUIpublic2016-05-13 10:292016-09-08 15:12
Mr.Bricodage 
fman 
normalfeature requestalways
closedfixed 
1.9.14 (2015 Q3) 
1.9.15 (2015 Q4) 
-
READY FOR TESTING
0007543: Display multilined text content according to text editor configuration
In my company, testlink is configured to use textplain editor for all text area.
Example for build description :
    $tlCfg->gui->text_editor['build'] = array( 'type' => 'none');

If I use LF during declaration (see attachment 01-edit.PNG), LF are not displayed in view page (see attachment 02-before.PNG). Testlink should display text according to configuration for all sections where LF can be used.

I modified testlink for buildView (provided in additional information, see attachment 03-after.PNG for GUI result).

I want to modify Testlink to display text according to configuration for all sections where LF can be used in textplain, but only if modifications are merged with TestLink official code.


Could you please :
- confirm that code modification are compliant with TestLink code rules ?
- Confirm that future code modification provided could be merged with trunk ?
- confirm that code modification should be sent through GitHub ?
modification example for buildView :

buildView.php
    require_once("web_editor.php");
    $editorCfg = getWebEditorCfg('build');
    $gui->editorType = $editorCfg['type'];

buildView.tpl
    <td>{$build.notes}</td>
==>
    <td>{if $gui->editorType eq 'none'}{$build.notes|nl2br}{else}{$build.notes}{/if}</td>
No tags attached.
related to 0007554closed fman TestProject View - Display multilined text content according to text editor configuration 
related to 0007555closed fman Platform View - Display multilined text content according to text editor configuration 
related to 0007556closed fman TestPlan View - Display multilined text content according to text editor configuration 
related to 0007557closed fman Requirement Specifications View - Display multilined text content according to text editor configuration 
related to 0007558closed fman Test Specification View - Display multilined text content according to text editor configuration 
related to 0007559closed fman Test Execution View - Display multilined text content according to text editor configuration 
related to 0007560closed fman Report and Metrics - Display multilined text content according to text editor configuration 
related to 0007561closed fman Assign Requirements - Display multilined text content according to text editor configuration 
related to 0007562closed fman Search TestCases - Display multilined text content according to text editor configuration 
related to 0007563closed fman TestCases Version comparator - Display multilined text content according to text editor configuration 
related to 0007564closed fman Requirements Version Comparator - Display multilined text content according to text editor configuration 
related to 0007565closed fman TestCases Edition - Display multilined text content according to text editor configuration 
related to 0007544closed fman BUILD View - Display multilined text content according to text editor configuration 
related to 0007550closed fman Roles View - Display multilined text content according to text editor configuration 
png 01-edit.PNG (3,940) 2016-05-13 10:30
http://mantis.testlink.org/file_download.php?file_id=4435&type=bug
png

png 02-before.PNG (4,479) 2016-05-13 10:30
http://mantis.testlink.org/file_download.php?file_id=4436&type=bug
png

png 03-after.PNG (5,264) 2016-05-13 10:30
http://mantis.testlink.org/file_download.php?file_id=4437&type=bug
png
Issue History
2016-05-13 10:29Mr.BricodageNew Issue
2016-05-13 10:30Mr.BricodageFile Added: 01-edit.PNG
2016-05-13 10:30Mr.BricodageFile Added: 02-before.PNG
2016-05-13 10:30Mr.BricodageFile Added: 03-after.PNG
2016-05-13 17:10fmanNote Added: 0024824
2016-05-13 17:34fmanIssue cloned: 0007544
2016-05-13 17:34fmanRelationship addedrelated to 0007544
2016-05-13 17:37fmanNote Added: 0024826
2016-05-13 17:37fmanAssigned To => fman
2016-05-13 17:37fmanStatusnew => feedback
2016-05-17 09:31Mr.BricodageRelationship addedrelated to 0007550
2016-05-17 09:38Mr.BricodageNote Added: 0024839
2016-05-17 09:38Mr.BricodageStatusfeedback => assigned
2016-05-17 09:39Mr.BricodageNote Edited: 0024839bug_revision_view_page.php?bugnote_id=24839#r4877
2016-05-20 08:30Mr.BricodageRelationship addedrelated to 0007554
2016-05-20 08:32Mr.BricodageRelationship addedrelated to 0007555
2016-05-20 08:34Mr.BricodageRelationship addedrelated to 0007556
2016-05-20 09:43Mr.BricodageRelationship addedrelated to 0007557
2016-05-20 09:43Mr.BricodageRelationship addedrelated to 0007558
2016-05-20 09:43Mr.BricodageRelationship addedrelated to 0007559
2016-05-20 09:43Mr.BricodageRelationship addedrelated to 0007560
2016-05-21 00:57Mr.BricodageRelationship addedrelated to 0007561
2016-05-21 00:57Mr.BricodageRelationship addedrelated to 0007562
2016-05-21 00:57Mr.BricodageRelationship addedrelated to 0007563
2016-05-21 00:58Mr.BricodageRelationship addedrelated to 0007564
2016-05-21 00:58Mr.BricodageRelationship addedrelated to 0007565
2016-06-26 09:35Mr.BricodageNote Added: 0025021
2016-06-27 05:44fmanQA Team - Task Workflow Status => READY FOR TESTING
2016-06-27 05:44fmanStatusassigned => resolved
2016-06-27 05:44fmanFixed in Version => 1.9.15 (2015 Q4)
2016-06-27 05:44fmanResolutionopen => fixed
2016-09-08 15:12fmanNote Added: 0025223
2016-09-08 15:12fmanStatusresolved => closed

Notes
(0024824)
fman   
2016-05-13 17:10   
Your solution is ok, but I would prefer a little bit different implementation.

I will move getWebEditorCfg($feature='all')

 inside common.php

Wait Till I confirm the change, then go ahead with your changes

regards
(0024826)
fman   
2016-05-13 17:37   
see related issue.
Please open one issue for feature you will fix.
(0024839)
Mr.Bricodage   
2016-05-17 09:38   
(edited on: 2016-05-17 09:39)
I just created 0007550 for roles.
Waiting your confirmation that I understood your code submission process before sending others modifications.

(0025021)
Mr.Bricodage   
2016-06-26 09:35   
should be marked as resolved as soon as linked issues will be marked as resolved
(0025223)
fman   
2016-09-08 15:12   
1.9.15 Released - 2016-09-08