MantisBT - TestLink
View Issue Details
0006250TestLinkUsers and Rightspublic2014-03-13 20:162014-04-25 17:38
gnustavo 
fman 
normalminoralways
closedfixed 
1.9.8 (2013 Q3 - bug fixing) 
1.9.10 (2014 Q1 - bug fixing) 
MySQL
READY FOR TESTING
0006250: Cannot set new rights after upgrade to 1.9.8
It seems that issue 0005746 was closed but not fixed. I tried to comment on it but couldn't find a way. I assume I cannot comment on closed issues, so I'm opening a new one. Sorry if this isn't the correct protocol.

I've upgraded from TestLink 1.9.4 to 1.9.8 and noticed that I couldn't change some specific rights on specific roles. This is exactly the problem reported on 0005746, which was closed with a message implying that the bug had been fixed on TL 1.9.8.

However, it doesn't seem to have been. I had to make the following adjustments in the database (MySQL) by hand to fix it:

insert into rights (id,description) values (35,'exec_edit_notes');
insert into rights (id,description) values (36,'exec_delete');
insert into rights (id,description) values (37,'testplan_unlink_executed_testcases');
insert into rights (id,description) values (38,'testproject_delete_executed_testcases');
insert into rights (id,description) values (39,'testproject_edit_executed_testcases');
insert into role_rights (role_id,right_id) values (8,35);
insert into role_rights (role_id,right_id) values (8,36);
insert into role_rights (role_id,right_id) values (8,37);
insert into role_rights (role_id,right_id) values (8,38);
insert into role_rights (role_id,right_id) values (8,39);

These SQL statements should be present on the database upgrade scripts on lib/sql/alter_tables/1.9.*/*/DB*/step1/db_schema_update.sql but I coudn't find them.

It seems they aren't there on TL 1.9.9 also...
The same reported on 0005746.
No tags attached.
related to 0005746closed fman Cannot set new rights after upgrade 
child of 0006048closed fman Availables hot-fixes for 1.9.9 & How To get full fixed package from gitorious 
Issue History
2014-03-13 20:16gnustavoNew Issue
2014-03-13 21:16fmanNote Added: 0020577
2014-03-13 21:17fmanNote View State: 0020577: public
2014-03-13 21:22fmanNote Edited: 0020577bug_revision_view_page.php?bugnote_id=20577#r3411
2014-03-13 21:24fmanNote Edited: 0020577bug_revision_view_page.php?bugnote_id=20577#r3412
2014-03-13 21:25fmanNote Edited: 0020577bug_revision_view_page.php?bugnote_id=20577#r3413
2014-03-13 21:26fmanNote Edited: 0020577bug_revision_view_page.php?bugnote_id=20577#r3414
2014-03-13 21:27fmanNote Added: 0020578
2014-03-13 21:27fmanRelationship addedrelated to 0005746
2014-03-13 21:28fmanNote Added: 0020579
2014-03-13 21:29fmanQA Team - Task Workflow Status => TBD
2014-03-14 11:22gnustavoNote Added: 0020580
2014-03-14 19:15fmanSummaryCannot set new rights after upgrade => Cannot set new rights after upgrade to 1.9.8
2014-03-14 19:16fmanQA Team - Task Workflow StatusTBD => READY FOR TESTING
2014-03-14 19:16fmanNote Added: 0020584
2014-03-14 19:16fmanStatusnew => resolved
2014-03-14 19:16fmanFixed in Version => 1.9.10 (2014 Q1 - bug fixing)
2014-03-14 19:16fmanResolutionopen => fixed
2014-03-14 19:16fmanAssigned To => fman
2014-03-14 19:16fmanRelationship addedchild of 0006048
2014-03-14 19:27gnustavoNote Added: 0020585
2014-04-25 17:38fmanNote Added: 0020817
2014-04-25 17:38fmanStatusresolved => closed

Notes
(0020577)
fman   
2014-03-13 21:16   
(edited on: 2014-03-13 21:26)
Issue has been fixed in this way:
Fresh install of 1.9.8 has all needed records.
I suppose a better explanation was needed explained the resolution
Solution was: on 1.9.7 some records were missing, then they were added on 1.9.8 COMPLETE INSTALL => the issue will not be present on 1.9.8.


Fresh install of 1.9.9 has all records, and because is supposed that upgrade to 1.9.9 is done from an 1.9.8, there is no need to provide this inserts.

Remember we request manual and incremental upgrade from one minor version to the next one.


May be adding the missing inserts is needed on 1.9.8, avoid the issue.

(0020578)
fman   
2014-03-13 21:27   
>> I assume I cannot comment on closed issues, so I'm opening a new one. Sorry if >> this isn't the correct protocol.
you can try to reopen it
(0020579)
fman   
2014-03-13 21:28   
Do not use 1.9.8, when a newer stable release exists.
(1.9.9 with latest fixes)
(0020580)
gnustavo   
2014-03-14 11:22   
I upgraded from 1.9.4 to 1.9.8. I had to postpone the upgrade to 1.9.9 because it requires PHP > 5.4 but I'm using CentOS 6.5 which still ships PHP 5.3.3. Going to 1.9.8 was easier and already brought most of the fixes and improvements since 1.9.4.

As for the upgrade procedure, I followed the instructions under the "Automatic upgrading with DB schema changes" section of the Installation Manual and applied the SQL upgrade scripts for 1.9.6 and 1.9.8. I understood that this should bring the database to the 1.9.8 level. But since those records are missing the upgrade wasn't complete. Shouldn't those records have been inserted by the SQL upgrade scripts?
(0020584)
fman   
2014-03-14 19:16   
https://gitorious.org/testlink-ga/testlink-code/commit/60d6ea1ef2f3c510669a5ec61038307bc43a9a3f [^]
(0020585)
gnustavo   
2014-03-14 19:27   
Great! Thanks.
(0020817)
fman   
2014-04-25 17:38   
1.9.10 released